search

HENNGE / aiodynamo

Asynchronous, fast, pythonic DynamoDB Client
https://aiodynamo.readthedocs.io/
Other
69 stars 20 forks source link

Bump pyfakefs to support Python 3.12 #172

Closed dimaqq closed 6 months ago

dimaqq commented 6 months ago

Older pyfakefs fails with:

    flavour = pathlib._Flavour  # type: ignore [attr-defined]
              ^^^^^^^^^^^^^^^^
AttributeError: module 'pathlib' has no attribute '_Flavour'
dimaqq commented 6 months ago

poke @ojii

dimaqq commented 6 months ago

I can't merge this PR until GHA completes and GHA won't run until maintainer approves running the workflow on the PR 🙇🏻

y26805 commented 6 months ago

I can't merge this PR until GHA completes and GHA won't run until maintainer approves running the workflow on the PR 🙇🏻

approved the run! looks mergeable now 🙏

dimaqq commented 6 months ago

let me fix typing complaints and hopefully it will be all good.

P.S.

Only those with write access to this repository can merge pull requests.

dimaqq commented 6 months ago

@y26805 please consider allowing GHA again 🙇🏻 and maybe merge it if all checks pass, because I'm not allowed to 🙇🏻

y26805 commented 6 months ago

looks like all tests passed, will merge this. thanks @dimaqq 🙏