search

HENNGE / arsenic

Async WebDriver implementation for asyncio and asyncio-compatible frameworks
Other
349 stars 52 forks source link

Safari [wip] #117

Closed dimaqq closed 3 years ago

dimaqq commented 3 years ago 
tests/test_real_browsers.py::test_get_page_source[safari] PASSED                                                                                [  5%]
tests/test_real_browsers.py::test_element_not_found[safari] PASSED                                                                              [ 11%]
tests/test_real_browsers.py::test_simple_form_submit[safari] PASSED                                                                             [ 17%]
tests/test_real_browsers.py::test_selector_types[safari-SelectorType.css_selector-.classname-Class Name] PASSED                                 [ 23%]
tests/test_real_browsers.py::test_selector_types[safari-SelectorType.link_text-link text-link text] PASSED                                      [ 29%]
tests/test_real_browsers.py::test_selector_types[safari-SelectorType.partial_link_text-partial-partial link text] PASSED                        [ 35%]
tests/test_real_browsers.py::test_selector_types[safari-SelectorType.tag_name-h2-Title Here] PASSED                                             [ 41%]
tests/test_real_browsers.py::test_selector_types[safari-SelectorType.xpath-.//h2-Title Here] PASSED                                             [ 47%]
tests/test_real_browsers.py::test_displayed[safari] FAILED                                                                                      [ 52%]
tests/test_real_browsers.py::test_execute_script[safari] FAILED                                                                                 [ 58%]
tests/test_real_browsers.py::test_cookies[safari] PASSED                                                                                        [ 64%]
tests/test_real_browsers.py::test_chained_actions[safari] PASSED                                                                                [ 70%]
tests/test_real_browsers.py::test_get_screenshot[safari] PASSED                                                                                 [ 76%]
tests/test_real_browsers.py::test_get_rect[safari] PASSED                                                                                       [ 82%]
tests/test_real_browsers.py::test_file_upload[safari] PASSED                                                                                    [ 88%]
tests/test_real_browsers.py::test_change_window[safari] PASSED                                                                                  [ 94%]
tests/test_real_browsers.py::test_request[safari] PASSED                                                                                        [100%]
dimaqq commented 3 years ago

@ojii help needed :)

ojii commented 3 years ago

safaridriver doesn't seem to implement Element Displayness

ojii commented 3 years ago

safaridriver doesn't seem to implement Element Displayness

Option 1: make the API unavailable for Safari

Option 2: implement the API in JS like selenium does

dimaqq commented 3 years ago

safaridriver doesn't seem to implement Element Displayness

Option 1: make the API unavailable for Safari

Option 2: implement the API in JS like selenium does

Interesting, webkit seems to implement it: https://trac.webkit.org/browser/webkit/trunk/Source/WebDriver/WebDriverService.cpp#L1565

Let me try Safari TP 🧻

dimaqq commented 3 years ago

Safari TP 🧻 fails on exactly same set of tests as Safari.