HENNGE / arsenic

Async WebDriver implementation for asyncio and asyncio-compatible frameworks
Other
349 stars 52 forks source link

Negative results from WebDriver are not Errors #122

Closed usrlocalben closed 3 years ago

usrlocalben commented 3 years ago

...or put another way, correctly transporting errors is not itself an error.

For example, in many test situations the most likely message traffic between Arsenic and WebDriver will be "NoSuchElement" as test implementations sit in wait_for_element() polling loops. These exceptions are mischaracterized as "errors," resulting in noisy log output--and confusion.

Logging all exceptions that occur also results in double-logging, since responses are already logged.

dimaqq commented 3 years ago

Code is fine; I'm ambivalent about the semantics change 🤷🏿

dimaqq commented 3 years ago

@ojii poke