HENNGE / arsenic

Async WebDriver implementation for asyncio and asyncio-compatible frameworks
Other
349 stars 52 forks source link

Make CI faster #157

Open y26805 opened 1 year ago

y26805 commented 1 year ago

Currently build is quite slow (> 8m), and if a test fails we need to re-try the entire job.

image

This PR aims to make builds faster, by

ojii commented 1 year ago
  • checking in poetry.lock for faster package resolution

I do not like this for libraries. CI should run against the latest versions

ojii commented 1 year ago

I wonder if we should just port this to GHA like I did for aiodynamo. There I also made it so poetry only locks in one step that is re-used by the rest.

y26805 commented 1 year ago
  • checking in poetry.lock for faster package resolution

I do not like this for libraries. CI should run against the latest versions

yeah thats fair

y26805 commented 1 year ago

I wonder if we should just port this to GHA like I did for aiodynamo. There I also made it so poetry only locks in one step that is re-used by the rest.

yeah GHA could work too.. whichever CI tool we use though, think we should separate out browser tests (relatively flaky) vs other tests