search

HENNGE / arsenic

Async WebDriver implementation for asyncio and asyncio-compatible frameworks
Other
350 stars 53 forks source link

including timeout in session get method #66

Closed cjlcarvalho closed 3 years ago

cjlcarvalho commented 5 years ago

Related to https://github.com/HDE/arsenic/issues/65

cjlcarvalho commented 5 years ago

There are some problems with the close method from Webdriver, as it raises a ProcessLookupError in some cases where a timeout happened in the communication with the driver, so instead of allowing that this exception reaches the user, I have changed it to raise a ArsenicError as it can be easily detected rather than another generic exception.

cjlcarvalho commented 5 years ago

Is the test pipeline ok? I have noticed that the CircleCI environment is always failing in the remote-session tests. @ojii

ojii commented 3 years ago

merged in #96