search

HENNGE / arsenic

Async WebDriver implementation for asyncio and asyncio-compatible frameworks
Other
351 stars 54 forks source link

Support new geckodriver #86

Closed dimaqq closed 4 years ago

dimaqq commented 4 years ago

Should resolve #85 and #84

dimaqq commented 4 years ago

@tarekziade a penny for your thoughts

dimaqq commented 4 years ago

PhantomJS tests fail... maybe it's time to remove them?

ojii commented 4 years ago

The version check should be updated to whatever version is the lowest that supports this change.

PhantomJS tests fail... maybe it's time to remove them?

Probably about time...

tarekziade commented 4 years ago

@ojii the content-type header is being verified since 0.27.0 https://github.com/mozilla/geckodriver/releases

dimaqq commented 4 years ago

The version check should be updated to whatever version is the lowest that supports this change.

Looks like the current check if version < StrictVersion("0.16.1"): is appropriate according to this comment: https://github.com/HDE/arsenic/issues/84#issuecomment-688036863