HEP-FCC / FCCAnalyses

Common analysis framework for the Future Circular Collider
https://hep-fcc.github.io/FCCAnalyses/
23 stars 115 forks source link

Missing streamer infos? #295

Open Zehvogel opened 1 year ago

Zehvogel commented 1 year ago

Looks like FCCAnalyses might not close the output files correctly? They are missing streamer infos needed to be viewed with jsroot.

see: https://github.com/root-project/jsroot/issues/259

kjvbrt commented 1 year ago

Hi @Zehvogel,

Thanks for reporting an issue :)

Even with using with TFile context almost everywhere (PR https://github.com/HEP-FCC/FCCAnalyses/pull/298) I'm still not able to get the JSROOT load the branch. See screenshot of the JS console at the bottom.

Quickly looking at the RVec reference page I can't see Streamer method.

Can you check with your analysis/file?

Screenshot from 2023-07-06 14-14-07

Zehvogel commented 11 months ago

I cannot reproduce this issue anymore, seems to work fine at the moment :)

Zehvogel commented 11 months ago

nvm, just ran into it again :/ the file I used is https://github.com/Zehvogel/resolutions/blob/main/analysis_stage1.py The first root file created by this has the correct streamer infos and every following file is missing them... I will try to make a smaller reproducer but so far I was not successful