search

HEP-FCC / FCCAnalyses

Common analysis framework for the Future Circular Collider
https://hep-fcc.github.io/FCCAnalyses/
22 stars 112 forks source link

Validation of whizard lhe output #372

Closed ZBahariyoon closed 4 months ago

kjvbrt commented 4 months ago

Hi @ZBahariyoon :)

I believe your validation.py script should go into examples directory or to https://github.com/HEP-FCC/FCCeePhysicsPerformance.

From which process are your LHE files coming from?

Please, do not overwrite case-studies/README.md file.

Best, Juraj

ZBahariyoon commented 4 months ago

Dear Juraj Thanks a lot for your email. I have not intended to make a merge request on this files. It was just for my local git usage. Are you suggesting that I make this changes and ask to merge in the main repository? Best Zohreh On Mon, May 13, 2024 at 12:36 Juraj Smiesko @.***> wrote:

Hi @ZBahariyoon https://github.com/ZBahariyoon :)

I believe your validation.py script should go into examples directory or to https://github.com/HEP-FCC/FCCeePhysicsPerformance.

From which process are your LHE files coming from?

Please, do not overwrite case-studies/README.md file.

Best, Juraj

— Reply to this email directly, view it on GitHub https://github.com/HEP-FCC/FCCAnalyses/pull/372#issuecomment-2107039429, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGETWG27AWKJEXBAJXMBFVLZCB7CPAVCNFSM6AAAAABHRKPUPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXGAZTSNBSHE . You are receiving this because you were mentioned.Message ID: @.***>

kjvbrt commented 4 months ago

Hi @ZBahariyoon,

I have not intended to make a merge request on this files. It was just for my local git usage.

I see.

Are you suggesting that I make this changes and ask to merge in the main repository?

If you think it will be useful for others. Your merge request is already in the main repository :)

Best, Juraj

ZBahariyoon commented 4 months ago

Dear Juraj, Sorry I made a mistake, please reject my merge request. The best, Zohreh

On Mon, May 13, 2024 at 13:31 Juraj Smiesko @.***> wrote:

Hi @ZBahariyoon https://github.com/ZBahariyoon,

I have not intended to make a merge request on this files. It was just for my local git usage.

I see.

Are you suggesting that I make this changes and ask to merge in the main repository?

If you think it will be useful for others. Your merge request is already in the main repository :)

Best, Juraj

— Reply to this email directly, view it on GitHub https://github.com/HEP-FCC/FCCAnalyses/pull/372#issuecomment-2107153554, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGETWGY7AZB576OJ36EVEC3ZCCFNZAVCNFSM6AAAAABHRKPUPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXGE2TGNJVGQ . You are receiving this because you were mentioned.Message ID: @.***>