search

HEP-FCC / FCCAnalyses

Common analysis framework for the Future Circular Collider
https://hep-fcc.github.io/FCCAnalyses/
24 stars 116 forks source link

Switch to Vertex updates in EDM4hep #382

Closed tmadlener closed 3 months ago

tmadlener commented 4 months ago

Switch from VertexData::primary to VertexData::type to accomodate for the changes that come with https://github.com/key4hep/EDM4hep/pull/329.

This should be transparent as far as the release is concerned, but will obviously break for all files that have been written with the nightlies so far. Until key4hep/EDM4hep#329 is merged, this will also not build on top of the nightlies until that is merged. Hence, these two PRs need to go in simultaneously.

I have tried to keep the semantics of all of the comparisons the same, but I am not entirely sure if I managed to. I will try to point out the places where it was not obvious to me.

AidanWiederhold commented 3 months ago

BTW @tmadlener is this related to this issue with the vertexing in v0.9.0 or is this only relevant for newer versions of the stack?

tmadlener commented 3 months ago

From a quick glance this should be completely independent from that issue. It looks as if something in the vertexing is (numerically) broken.

tmadlener commented 3 months ago

I think from my side this looks good. I can build this locally with the corresponding EDM4hep PR. Unless, there is something missing, I would suggest that we merge this either still today or next Monday (July 8), simultaneously with key4hep/EDM4hep#329 and the other PRs mentioned in there to not break the nightlies over the weekend.

kjvbrt commented 3 months ago

Hi @tmadlener, yes, I'm not sure we can easily test if there are no changes. Anyway, the previous versions of the analyzers will be kept in the releases and pred-edm4hep1 branch. Would you like still to merge this today?

tmadlener commented 3 months ago

Let's merge on Monday just in case I have overlooked something in my local testing.