HEP-FCC / heppy

[deprecated] A python analysis framework for high energy physics
Other
11 stars 32 forks source link

Update FCC context #87

Closed vvolkl closed 5 years ago

vvolkl commented 5 years ago

The FCC software no longer uses the environment variables it used to.

vvolkl commented 5 years ago

No problem! I was packaging heppy for use in a docker image and had a few more fixes. Would be great if you can take a look once I get around to opening the PRs.

@JavierCVilla could you check our jenkins instance? the build looks like something is wrong

cbernet commented 5 years ago

Btw heppy is now available on pypi: https://pypi.org/project/heppyfwk/

Maybe we want to pick it up from there now?

Cheers,

Colin

On 13 Feb 2019, at 13:35, vvolkl notifications@github.com<mailto:notifications@github.com> wrote:

No problem! I was packaging heppy for use in a docker image and had a few more fixes. Would be great if you can take a look once I get around to opening the PRs.

@JavierCVillahttps://github.com/JavierCVilla could you check our jenkins instance? the build looks like something is wrong

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/HEP-FCC/heppy/pull/87#issuecomment-463183432, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD8kuzXewbaEEZLuOdyCU_IbiByCh8F5ks5vNAaWgaJpZM4a5L3n.

clementhelsens commented 5 years ago

@cbernet, how do we handle FCC specific developments then?

Le 13 févr. 2019 à 13:41, Colin Bernet notifications@github.com<mailto:notifications@github.com> a écrit :

Btw heppy is now available on pypi: https://pypi.org/project/heppyfwk/

Maybe we want to pick it up from there now?

Cheers,

Colin

On 13 Feb 2019, at 13:35, vvolkl notifications@github.com<mailto:notifications@github.commailto:notifications@github.com> wrote:

No problem! I was packaging heppy for use in a docker image and had a few more fixes. Would be great if you can take a look once I get around to opening the PRs.

@JavierCVillahttps://github.com/JavierCVilla could you check our jenkins instance? the build looks like something is wrong

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/HEP-FCC/heppy/pull/87#issuecomment-463183432, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD8kuzXewbaEEZLuOdyCU_IbiByCh8F5ks5vNAaWgaJpZM4a5L3n.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/HEP-FCC/heppy/pull/87#issuecomment-463184932, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFBjDYeax27LRialR37xpDXfFbc1v-ykks5vNAfigaJpZM4a5L3n.

cbernet commented 5 years ago

As usual, we do Prs to HEP-FCC/heppy. And when the responsible person decides to draft a release, (s)he uploads to pypi

On 13 Feb 2019, at 14:14, clementhelsens notifications@github.com<mailto:notifications@github.com> wrote:

@cbernet, how do we handle FCC specific developments then?

Le 13 févr. 2019 à 13:41, Colin Bernet notifications@github.com<mailto:notifications@github.commailto:notifications@github.com> a écrit :

Btw heppy is now available on pypi: https://pypi.org/project/heppyfwk/

Maybe we want to pick it up from there now?

Cheers,

Colin

On 13 Feb 2019, at 13:35, vvolkl notifications@github.com<mailto:notifications@github.commailto:notifications@github.commailto:notifications@github.com> wrote:

No problem! I was packaging heppy for use in a docker image and had a few more fixes. Would be great if you can take a look once I get around to opening the PRs.

@JavierCVillahttps://github.com/JavierCVilla could you check our jenkins instance? the build looks like something is wrong

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/HEP-FCC/heppy/pull/87#issuecomment-463183432, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD8kuzXewbaEEZLuOdyCU_IbiByCh8F5ks5vNAaWgaJpZM4a5L3n.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/HEP-FCC/heppy/pull/87#issuecomment-463184932, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFBjDYeax27LRialR37xpDXfFbc1v-ykks5vNAfigaJpZM4a5L3n.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/HEP-FCC/heppy/pull/87#issuecomment-463194381, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD8ku6610NpKagYEhOBZiPNEL7RpC49eks5vNA-YgaJpZM4a5L3n.

JavierCVilla commented 5 years ago

@JavierCVilla could you check our jenkins instance? the build looks like something is wrong

The current CI setup was still using afs...

/afs/cern.ch/exp/fcc/sw/0.8pre/setup.sh

changing it to the current FCC externals.

JavierCVilla commented 5 years ago

Still failing

vvolkl commented 5 years ago

@JavierCVilla thanks, this looks now like an actual problem with the PR, will take a look

@cbernet great, I think using pypi is very nice!

JavierCVilla commented 5 years ago

@phsft-bot build

vvolkl commented 5 years ago

test this please

phsft-bot commented 5 years ago

All tests succeeded.

phsft-bot commented 5 years ago

All tests succeeded.

vvolkl commented 5 years ago

Superseded by #96