search

HEP-FCC / heppy

[deprecated] A python analysis framework for high energy physics
Other
11 stars 32 forks source link

[WIP] update's from David to get HTCONDOR batch jobs #94

Closed davidjamin closed 5 years ago

phsft-bot commented 5 years ago

Can one of the admins verify this patch?

vvolkl commented 5 years ago

Hi Colin, yes, gitpython has been available for a while in the central fcc installation, if there is an import error, it must come from an old configuration.

JavierCVilla commented 5 years ago

@vvolkl @JavierCVilla did you install gitpython by default in the last releases? (not sure which one David is using). It's really needed.

As far as I can see it is installed and working:

$ source /cvmfs/fcc.cern.ch/sw/views/releases/externals/latest/x86_64-slc6-gcc62-opt/setup.sh 
$ python
Python 2.7.15 (default, Jul 30 2018, 09:38:14) 
[GCC 6.2.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from git import Repo
>>> import git
>>>
vvolkl commented 5 years ago

@cbernet I think this PR was still work in progress. David mentioned that there are still a lot of failing jobs with condor, so we are looking into that. You can leave this and we can open another one, but just keep in mind condor submission is not production ready yet.

cbernet commented 5 years ago

@vvolkl I know that condor submission is not ready, and I understood that the issue needs to be fixed on the CERN IT side. @davidjamin told me that the PR had been updated and did not ask me to hold it. If a PR needs to be hold, please mention it in the comments or directly to me in private before pushing

vvolkl commented 5 years ago

It was marked with [WIP] (Work in Progress) in the title ;)

cbernet commented 5 years ago

I'd prefer to have plain PR messages and, when contacted on skype, to be explicitely told to hold the PR.

I was just told that on skype that the PR had been updated and that we now had to wait for the fixes from the help desk.

Please guys, I have very very little time for these things, I have left FCC, and I'm just looking at this to help you.

vvolkl commented 5 years ago

And that's highly appreciated! Sure, I just didn't get notified that the problem was now CERN IT side only, that's why I was still looking into the errrors. Sorry for the spam