search

HEP-KBFI / TallinnNtupleProducer

code, python scripts and config files for producing "plain" Tallinn Ntuples
3 stars 2 forks source link

Reduce data to mcsf code #16

Closed saswatinandan closed 2 years ago

saswatinandan commented 2 years ago

I see we have Data_to_MC_CorrectionInterface_Base.cc Data_to_MC_CorrectionInterface_2016.cc Data_to_MC_CorrectionInterface_2017.cc Data_to_MC_CorrectionInterface_2018.cc, 4 codes where era specific code are almost similar except root files and sf are different. We can use one file instead of 3 which is easy to look at all era dependent information in one file and also we don't need to track three files. If there is no specific reason to have 3 separate files, I'd like to use one file with all era dependent information and one with base information

ktht commented 2 years ago

Closing because not necessarily needed. I moved common members to the base class -- that's enough in my opinion. This PR would have to be rebased anyways.