search

HEP-KBFI / TallinnNtupleProducer

code, python scripts and config files for producing "plain" Tallinn Ntuples
3 stars 2 forks source link

Trigger sf #26

Open saswatinandan opened 1 year ago

saswatinandan commented 1 year ago

This is related to the issue. I guess we can simply check the filter bits of reco object to decide whether they are matched with trigger objects and if yes, consider only those reco objects to calculate sf. If it is fine, I'll check for 1l_3tau trigger also, currently implemented only for 4tau trigger case

saswatinandan commented 1 year ago

@ktht , did you miss this pull request by any chance or I made some major mistakes here?

ktht commented 1 year ago

Please test the code. I sense that there will be segfaults.

saswatinandan commented 1 year ago

I guess there is no option to test it, as the corresponding channel is missing now, I belive

ktht commented 1 year ago

But you can change the config minimally such that the relevant piece of code will be executed.

saswatinandan commented 1 year ago

I tried to check this but it is not possible to do by minimal changes as there is error not coming from trigger but before that. I don't see any such thing in cfg file https://github.com/HEP-KBFI/TallinnNtupleProducer/blob/main/EvtWeightTools/src/HadTauFakeRateInterface.cc#L86 I need one old cfg file to see how it works.

saswatinandan commented 1 year ago

But you can change the config minimally such that the relevant piece of code will be executed.

checked on 4tau samples for 1k events, didn't encounter any error