search

HEP-PBSP / SIMUnet

The public code for SIMUnet, a NNPDF based tool to perform simultaneous determination of PDFs and EFT Wilson coefficients.
https://hep-pbsp.github.io/SIMUnet/
GNU General Public License v3.0
2 stars 2 forks source link

fixed bug in arclength function #11

Closed comane closed 1 year ago

comane commented 1 year ago

This PR fixes a bug in the validphys.arclength module. This bug was found in NNPDF some time ago: see https://github.com/NNPDF/nnpdf/pull/1681/files

Zaharid commented 1 year ago

Is this affecting any of our conclusions? I am thinking that backporting all the bugfixes is a slippery slope.

comane commented 1 year ago

I agree, but this affects vp-comparefits which we probably need

comane commented 1 year ago

@Zaharid , @LucaMantani I am merging this branch as it fixes a bug appearing when running vp-comparefits.

Error Log:


    ax.errorbar(
  File "/data/theorie/enocera/miniconda3/envs/nnpdf-dev/lib/python3.8/site-packages/matplotlib/__init__.py", line 1423, in inner
    return func(ax, *map(sanitize_sequence, args), **kwargs)
  File "/data/theorie/enocera/miniconda3/envs/nnpdf-dev/lib/python3.8/site-packages/matplotlib/axes/_axes.py", line 3595, in errorbar
    raise ValueError(
ValueError: 'yerr' must not contain negative values ```