search

HEP-PBSP / SIMUnet

The public code for SIMUnet, a NNPDF based tool to perform simultaneous determination of PDFs and EFT Wilson coefficients.
https://hep-pbsp.github.io/SIMUnet/
GNU General Public License v3.0
2 stars 2 forks source link

Theory uncertainties implemented #35

Open J-M-Moore opened 8 months ago

J-M-Moore commented 8 months ago

This PR implements the theory covariance matrix supplied in the simu_fac files. Currently only does things at the level of the fit, we also need to add this to the chi2 computation and the plots.

comane commented 8 months ago

This PR implements the theory covariance matrix supplied in the simu_fac files. Currently only does things at the level of the fit, we also need to add this to the chi2 computation and the plots.

Hi @J-M-Moore , thanks for this. Could you please add some more description / update the description of the PR ?

Also are there some checks/benchmark we can perform before merging this?

LucaMantani commented 8 months ago

It seems fine to me, I don't see mistakes.

The easy benchmark is to compare the two alpha_EW datasets, the one that contains the th_covmat in the commondata and the other by adding it in the fit

LucaMantani commented 8 months ago

@J-M-Moore or @comane Could you run a dumb fit of just cll in alphaEW, fixed PDF, in the two scenarios and verify that the results are the same? Than we can merge it.

comane commented 6 months ago

What is the status of this @J-M-Moore, are we planning on merging it or is this not needed anymore?