search

HEP-PBSP / SIMUnet

The public code for SIMUnet, a NNPDF based tool to perform simultaneous determination of PDFs and EFT Wilson coefficients.
https://hep-pbsp.github.io/SIMUnet/
GNU General Public License v3.0
2 stars 2 forks source link

Set ATLASLUMI13 systematics as MULT #44

Closed LucaMantani closed 9 months ago

LucaMantani commented 9 months ago

In a previous fix, we set all of the new Diboson systematics as type ADD. However, the systematic uncertainty ATLASLUMI13 exists in other ATLAS datasets as type MULT, and the inconsistency causes the fit to stop and crash.

This PR sets back the systematics as type MULT in the new Diboson datasets. This solves the inconsistency. I don't know if this has any impact at the level of the fit, given that I understood there was some problem with using MULT uncertainties.

What do you think @MaeveMadiganMM ? You changed the Diboson datasets so that all uncertainties are additive?

MaeveMadiganMM commented 9 months ago

Yes I think this is fine! There might be some misunderstanding, we only needed to change the numbers in the DATA files (as in this commit https://github.com/mariaubiali/simunet_release/commit/05b62392f493a993b0e930bf97416ff518fde688) because they were wrong before. I did this by modifying MULT->ADD in the smefit data files in the SimuRelease repo. Once the DATA files are fine, I think the systypes in the SYSTYPE files can all be kept as MULT, i.e. reverting this commit: https://github.com/mariaubiali/simunet_release/commit/3610ccc07bcaa19adab175a608ca99d76fe00286

LucaMantani commented 9 months ago

I see, ok :) I'll put them all back to MULT then!

LucaMantani commented 9 months ago

@MaeveMadiganMM If it's fine, approve and merge so this is done :)