search

HEP-Puppet / puppet-apelpublisher

A Puppet module to set up an Apel Publisher
1 stars 5 forks source link

Database fixes for #7. #9

Open rwf14f opened 10 years ago

rwf14f commented 10 years ago

Only includes Kashif's database fixes (plus a few of my own) and should be less problematic than merging all of Kashif's changes. I've tested it as much as I can, but someone else should have a glance over the changes before merging it.

kreczko commented 10 years ago

It looks good and can be automatically merged. I have two comments though (see above). The first is quite minor and I am not sure if it would cause any problem with puppet module install. The second might (or might not) be critical.

kreczko commented 10 years ago

Thanks again for the clarifications. Once name 'apelpublisher' is changed to name 'heppuppet-apelpublisher' I have no objections to the merge.