HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 26 forks source link

Further constrain tablespace #472

Closed jcpunk closed 3 years ago

jcpunk commented 3 years ago

As we try to hunt down #458 it is clear these additional constraints are needed for our data model.

codecov[bot] commented 3 years ago

Codecov Report

Merging #472 (ef02617) into master (94c1411) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   93.52%   93.53%           
=======================================
  Files          43       43           
  Lines        2703     2705    +2     
  Branches      384      384           
=======================================
+ Hits         2528     2530    +2     
  Misses        135      135           
  Partials       40       40           
Flag Coverage Δ
python-3.6 92.87% <100.00%> (+<0.01%) :arrow_up:
python-3.9 92.97% <100.00%> (+<0.01%) :arrow_up:
python-pypy-3.7 93.02% <100.00%> (-0.22%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...k/dataspace/datasources/sqlalchemy_ds/db_schema.py 100.00% <100.00%> (ø)
...ecisionengine/framework/taskmanager/TaskManager.py 96.78% <0.00%> (+0.01%) :arrow_up:
...rc/decisionengine/framework/dataspace/dataspace.py 88.50% <0.00%> (+0.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94c1411...ef02617. Read the comment docs.

StevenCTimm commented 3 years ago

This appears to operate successfully in the dev decision engine. Has run stably for quite some time. Will leave legality of the code to others to review.

mambelli commented 3 years ago

Just curious. Did you remove the fillfactor settings because we discussed that we should not update the data?