Closed goodenou closed 3 years ago
Hello @goodenou! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
This pull request fixes 1 alert when merging 62de90f1c3e4807206e8be479cf042c80e340a01 into 8cdeb67ea8a5020f381aa9eaa1a16221fe3c9a99 - view on LGTM.com
fixed alerts:
Merging #504 (1be91f2) into master (8cdeb67) will increase coverage by
0.45%
. The diff coverage is100.00%
.:exclamation: Current head 1be91f2 differs from pull request most recent head 266dadb. Consider uploading reports for the commit 266dadb to get more accurate results
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
+ Coverage 93.35% 93.81% +0.45%
==========================================
Files 43 43
Lines 2725 2748 +23
Branches 388 390 +2
==========================================
+ Hits 2544 2578 +34
+ Misses 135 129 -6
+ Partials 46 41 -5
Flag | Coverage Δ | |
---|---|---|
python-3.6 | 93.24% <100.00%> (?) |
|
python-3.9 | 93.33% <100.00%> (?) |
|
python-pypy-3.7 | 93.31% <100.00%> (-0.04%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...ionengine/framework/config/ChannelConfigHandler.py | 95.94% <100.00%> (+0.05%) |
:arrow_up: |
...rc/decisionengine/framework/dataspace/datablock.py | 98.82% <100.00%> (ø) |
|
...c/decisionengine/framework/dataspace/datasource.py | 100.00% <100.00%> (ø) |
|
...gine/framework/dataspace/datasources/postgresql.py | 82.44% <100.00%> (+1.14%) |
:arrow_up: |
...aspace/datasources/sqlalchemy_ds/datasource_api.py | 98.76% <100.00%> (+1.23%) |
:arrow_up: |
...ework/dataspace/datasources/sqlalchemy_ds/utils.py | 100.00% <100.00%> (+13.33%) |
:arrow_up: |
...rc/decisionengine/framework/dataspace/dataspace.py | 88.76% <100.00%> (+0.12%) |
:arrow_up: |
src/decisionengine/framework/dataspace/maintain.py | 98.13% <100.00%> (+1.04%) |
:arrow_up: |
.../decisionengine/framework/engine/DecisionEngine.py | 90.14% <100.00%> (ø) |
|
src/decisionengine/framework/engine/Workers.py | 87.50% <100.00%> (+0.35%) |
:arrow_up: |
... and 20 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8cdeb67...266dadb. Read the comment docs.
This pull request fixes 2 alerts when merging cdb77a76f2ed307987b61c37c9cd6562c4863538 into 8cdeb67ea8a5020f381aa9eaa1a16221fe3c9a99 - view on LGTM.com
fixed alerts:
This pull request fixes 2 alerts when merging 1544ce719328bf1089f2594cbc4efb36b9a37ec0 into 8cdeb67ea8a5020f381aa9eaa1a16221fe3c9a99 - view on LGTM.com
fixed alerts:
This pull request fixes 2 alerts when merging 5e65b8841868141af56e66daa4444f6b244e1711 into 8cdeb67ea8a5020f381aa9eaa1a16221fe3c9a99 - view on LGTM.com
fixed alerts:
This pull request fixes 2 alerts when merging 71410e23a1619bfda6a6a14957c3f53fb0d0bb5f into 8cdeb67ea8a5020f381aa9eaa1a16221fe3c9a99 - view on LGTM.com
fixed alerts:
This pull request fixes 2 alerts when merging 1be91f2ad7b1b6caf4a30f33588890b8b6f1f5b6 into 8cdeb67ea8a5020f381aa9eaa1a16221fe3c9a99 - view on LGTM.com
fixed alerts:
This pull request fixes 2 alerts when merging 266dadb654f20da1060c73ad622064306af3e9e5 into 8cdeb67ea8a5020f381aa9eaa1a16221fe3c9a99 - view on LGTM.com
fixed alerts:
Let's try this again. Here we have all channel loggers called "channel", but they log to different files.