search

HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 26 forks source link

Run flake8 test also when packaging fails #511

Closed mambelli closed 3 years ago

mambelli commented 3 years ago

flake8 tests also for errors, not only styles. Unit tests could fail also if there are problems in the packaging (different versions of packaging and requirement packages, setup tools configuration). A recent problem w/ automatic versions hid a problem with an undeclared variable.

So flake8 should run all the time, also when unit tests or packaging fail, and directly on the sources, it can run checking out sources from the decisionengine and decisionengine_modules repositories (without pip installing them), so it should.

jcpunk commented 3 years ago

Should be fixed in https://github.com/HEPCloud/decisionengine/pull/510