HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 25 forks source link

Remove now-unnecessary Python-to-Jsonnet conversion #516

Closed knoepfel closed 2 years ago

knoepfel commented 2 years ago

Now that DE production uses valid Jsonnet files, we can remove the Python-to-Jsonnet conversion facility that was put in place during the configuration-system overhaul. Cleaning up the configuration system will be helpful as part of the source-proxy replacement, especially as we start assembling workflows using Jsonnet configuration facilities.

codecov[bot] commented 2 years ago

Codecov Report

Merging #516 (f7c52cc) into master (a6a81ce) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   93.86%   93.84%   -0.02%     
==========================================
  Files          44       44              
  Lines        2754     2730      -24     
  Branches      391      389       -2     
==========================================
- Hits         2585     2562      -23     
+ Misses        129      127       -2     
- Partials       40       41       +1     
Flag Coverage Δ
python-3.6 93.27% <100.00%> (+0.01%) :arrow_up:
python-3.9 93.36% <100.00%> (+0.05%) :arrow_up:
python-pypy-3.7 93.42% <100.00%> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/decisionengine/framework/config/ValidConfig.py 100.00% <100.00%> (+4.65%) :arrow_up:
src/decisionengine/framework/dataspace/maintain.py 98.11% <0.00%> (-0.95%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6a81ce...f7c52cc. Read the comment docs.