HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 25 forks source link

Various simplifications recommended by flake8-simple #518

Closed jcpunk closed 2 years ago

jcpunk commented 2 years ago

These changes are mostly modernization elements

pep8speaks commented 2 years ago

Hello @jcpunk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-09-21 17:28:11 UTC
codecov[bot] commented 2 years ago

Codecov Report

Merging #518 (c818e55) into master (a6a81ce) will decrease coverage by 10.35%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #518       +/-   ##
===========================================
- Coverage   93.86%   83.50%   -10.36%     
===========================================
  Files          44       47        +3     
  Lines        2754     3092      +338     
  Branches      391      433       +42     
===========================================
- Hits         2585     2582        -3     
- Misses        129      470      +341     
  Partials       40       40               
Flag Coverage Δ
python-3.6 82.97% <100.00%> (-10.29%) :arrow_down:
python-3.9 83.13% <83.33%> (-10.19%) :arrow_down:
python-pypy-3.7 83.10% <100.00%> (-10.38%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/decisionengine/framework/dataspace/maintain.py 98.11% <ø> (-0.95%) :arrow_down:
...rc/decisionengine/framework/dataspace/datablock.py 98.82% <100.00%> (ø)
...gine/framework/dataspace/datasources/postgresql.py 84.10% <100.00%> (+1.66%) :arrow_up:
.../decisionengine/framework/engine/DecisionEngine.py 90.22% <100.00%> (+0.02%) :arrow_up:
...isionengine/framework/modules/print_description.py 98.71% <100.00%> (ø)
...ionengine/framework/config/ChannelConfigHandler.py 95.94% <0.00%> (ø)
...ecisionengine/framework/managers/ChannelManager.py 0.00% <0.00%> (ø)
...ne/framework/managers/SourceSubscriptionManager.py 0.00% <0.00%> (ø)
...decisionengine/framework/managers/SourceManager.py 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6a81ce...c818e55. Read the comment docs.