Closed knoepfel closed 2 years ago
Merging #524 (67780cc) into master (a4a7938) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #524 +/- ##
==========================================
+ Coverage 83.39% 83.40% +0.01%
==========================================
Files 47 47
Lines 3089 3091 +2
Branches 433 434 +1
==========================================
+ Hits 2576 2578 +2
Misses 473 473
Partials 40 40
Flag | Coverage Δ | |
---|---|---|
python-3.6 | 82.86% <100.00%> (+0.01%) |
:arrow_up: |
python-3.9 | 82.99% <100.00%> (-0.03%) |
:arrow_down: |
python-pypy-3.7 | 82.99% <100.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/decisionengine/framework/config/ValidConfig.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a4a7938...67780cc. Read the comment docs.
This looks good to me.
The facilities provided by this PR enable assembling channel configurations in a composable way. See the below example.
This PR also provides the ability to specify Jsonnet path directories when loading Jsonnet file.
Consider the two Jsonnet configurations:
A.libsonnet
B.libsonnet
They can be combined via the following configuration:
Final.jsonnet
The final JSON configuration would look like:
Note that the source-proxy configurations are not persisted.