HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 26 forks source link

Improve parameter and variable names #527

Closed knoepfel closed 3 years ago

knoepfel commented 3 years ago

This fix partly addresses https://github.com/HEPCloud/decisionengine_modules/issues/253.

pep8speaks commented 3 years ago

Hello @knoepfel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-09-30 18:30:12 UTC
codecov[bot] commented 3 years ago

Codecov Report

Merging #527 (c37aebc) into master (590bea3) will increase coverage by 0.05%. The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
+ Coverage   83.40%   83.45%   +0.05%     
==========================================
  Files          47       47              
  Lines        3091     3089       -2     
  Branches      434      434              
==========================================
  Hits         2578     2578              
+ Misses        473      472       -1     
+ Partials       40       39       -1     
Flag Coverage Δ
python-3.6 82.88% <35.71%> (+0.02%) :arrow_up:
python-3.9 83.05% <35.71%> (+0.02%) :arrow_up:
python-pypy-3.7 83.05% <35.71%> (+0.11%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ecisionengine/framework/managers/ChannelManager.py 0.00% <0.00%> (ø)
...decisionengine/framework/managers/SourceManager.py 0.00% <0.00%> (ø)
...rc/decisionengine/framework/modules/SourceProxy.py 65.21% <50.00%> (ø)
...ecisionengine/framework/taskmanager/TaskManager.py 96.49% <100.00%> (-0.02%) :arrow_down:
src/decisionengine/framework/dataspace/maintain.py 99.05% <0.00%> (+0.94%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 590bea3...c37aebc. Read the comment docs.