search

HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 26 forks source link

Update license and add copyright notices #528

Closed mambelli closed 2 years ago

mambelli commented 3 years ago

Pending Fermilab evaluation we'll update the License to Apache 2.0 as suggested during the stakeholders meeting, and add copyright notices on top of all files (recommended). This should wait first for the response from Fermilab legal office. The plan is to use SPDX and tools like pre-commit hooks or REUSE for the initial insertion of the notices and for the upkeep. This will affect both framework and modules.

knoepfel commented 3 years ago

Thanks, @mambelli, for the issue report. Would it be possible to omit the copyright/license notices for any files under the test or tests subdirectories? Note that those files are still licensed, they just don't have the extra blurb at the top. I'm just thinking of reducing visual clutter.

If that suggestion opens up a can of worms, then you can disregard it.

mambelli commented 3 years ago

@knoepfel, I don't like extra blurbs either. I'll check but it seems we should add it also to the tests. In the end, it will be 2 comment lines after the eventual shebang, managed automatically, something like:

# SPDX-FileCopyrightText: 2018 Fermi Research Alliance, LLC
# SPDX-License-Identifier: Apache-2.0
knoepfel commented 3 years ago

@mambelli, thank you for the clarification. I can live with 2 comment lines--I didn't grasp the SPDX part earlier. I have no more concerns.

mambelli commented 2 years ago

Merged in master, DE #575