HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 25 forks source link

Add instructions for running the Redis container. #553

Closed jcpunk closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #553 (3faa53e) into master (4f920dc) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 3faa53e differs from pull request most recent head 5aa9506. Consider uploading reports for the commit 5aa9506 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #553   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files          46       46           
  Lines        2852     2852           
  Branches      464      464           
=======================================
  Hits         2715     2715           
  Misses        103      103           
  Partials       34       34           
Flag Coverage Δ
python-3.10 95.05% <ø> (-0.04%) :arrow_down:
python-3.6 94.93% <ø> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f920dc...5aa9506. Read the comment docs.

mambelli commented 2 years ago

@jcpunk Do you know if this will be OK to run on fermicloud or if we'll need a license or alternative to the docker command starting January?

jcpunk commented 2 years ago

Hmm, I forgot about the license change.

I've switched the doc to reference podman which is a dropin replacement for docker in most cases.

mambelli commented 2 years ago

@jcpunk, did anything change in the code in the last push? Strangely it shows the same errors in the unit tests that Lisa is having, and the previous one was OK.

jcpunk commented 2 years ago

I believe these errors are fixed in https://github.com/HEPCloud/decisionengine/pull/555