adding queue logger for multiprocess logging

HEPCloud / decisionengine

HEPCloud Decision Engine framework

Apache License 2.0

6 stars 25 forks source link

adding queue logger for multiprocess logging #554

Closed goodenou closed 2 years ago

goodenou commented 2 years ago

trying a new pull request. not sure why tests are failing.

pep8speaks commented 2 years ago

Hello @goodenou! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-11-12 20:29:23 UTC

jcpunk commented 2 years ago

There seems to be something weird with the stop methods causing the unit tests to fail.... I've not figured out what is wrong, but it seems localized to there.

_ ERROR at teardown of test_client_print_product_vertical[SQLALCHEMY_PG_WITH_SCHEMA] _

>       server_proc.de_server.rpc_stop()

>       self._thread.join()
E       AttributeError: 'NoneType' object has no attribute 'join'

goodenou commented 2 years ago

Issues with unit tests, were, I believe, related to the creation of a queue logger which was not used and shut down properly in the tests. I have added a flag for not creating the queue logger in the unit tests, and have put that code in a new PR.