search

HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 25 forks source link

Drop obsolete raw postgresql interface #558

Closed jcpunk closed 2 years ago

jcpunk commented 2 years ago

Now that we've been running on SQLAlchemy in production for a while, we can remove the old interface.

pep8speaks commented 2 years ago

Hello @jcpunk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-11-11 19:43:11 UTC
codecov[bot] commented 2 years ago

Codecov Report

Merging #558 (b07f3b9) into master (91f7a76) will increase coverage by 0.49%. The diff coverage is n/a.

:exclamation: Current head b07f3b9 differs from pull request most recent head 711dab1. Consider uploading reports for the commit 711dab1 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage   94.64%   95.14%   +0.49%     
==========================================
  Files          46       45       -1     
  Lines        2934     2675     -259     
  Branches      476      387      -89     
==========================================
- Hits         2777     2545     -232     
+ Misses        121       95      -26     
+ Partials       36       35       -1
Flag Coverage Δ
python-3.10 ?
python-3.6 95.14% <ø> (+0.75%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ework/dataspace/datasources/sqlalchemy_ds/utils.py 86.66% <0.00%> (-13.34%) :arrow_down:
...aspace/datasources/sqlalchemy_ds/datasource_api.py 97.53% <0.00%> (-1.24%) :arrow_down:
src/decisionengine/framework/dataspace/maintain.py 99.00% <0.00%> (-1.00%) :arrow_down:
.../decisionengine/framework/engine/DecisionEngine.py 86.84% <0.00%> (-0.53%) :arrow_down:
...rc/decisionengine/framework/dataspace/dataspace.py 88.63% <0.00%> (-0.13%) :arrow_down:
src/decisionengine/framework/modules/Transform.py 100.00% <0.00%> (ø)
...ionengine/framework/taskmanager/ProcessingState.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91f7a76...711dab1. Read the comment docs.