Closed knoepfel closed 2 years ago
Merging #564 (82865bc) into master (b85dca4) will increase coverage by
14.51%
. The diff coverage is100.00%
.:exclamation: Current head 82865bc differs from pull request most recent head ce6a30d. Consider uploading reports for the commit ce6a30d to get more accurate results
@@ Coverage Diff @@
## master #564 +/- ##
===========================================
+ Coverage 81.31% 95.83% +14.51%
===========================================
Files 45 45
Lines 2719 2665 -54
Branches 495 430 -65
===========================================
+ Hits 2211 2554 +343
+ Misses 470 79 -391
+ Partials 38 32 -6
Flag | Coverage Δ | |
---|---|---|
python-3.10 | 95.72% <98.92%> (+14.47%) |
:arrow_up: |
python-3.6 | 95.51% <100.00%> (+14.54%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/decisionengine/framework/engine/Workers.py | 86.95% <ø> (+18.46%) |
:arrow_up: |
.../decisionengine/framework/engine/DecisionEngine.py | 89.11% <100.00%> (+56.28%) |
:arrow_up: |
...ecisionengine/framework/logicengine/LogicEngine.py | 100.00% <100.00%> (ø) |
|
...isionengine/framework/managers/ComponentManager.py | 100.00% <100.00%> (+17.07%) |
:arrow_up: |
...ecisionengine/framework/taskmanager/TaskManager.py | 98.26% <100.00%> (+11.53%) |
:arrow_up: |
...ionengine/framework/config/ChannelConfigHandler.py | 95.94% <0.00%> (+1.35%) |
:arrow_up: |
src/decisionengine/framework/modules/Module.py | 100.00% <0.00%> (+8.10%) |
:arrow_up: |
... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b85dca4...ce6a30d. Read the comment docs.
Hello @knoepfel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Looks good to me, can you squash down to one commit?
@jcpunk, commits have been squashed.
This PR makes various cleanups before moving to a system with sources separated from channels.