search

HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 25 forks source link

Set state to error for exceptions caught before the thread start. #570

Closed jcpunk closed 2 years ago

jcpunk commented 2 years ago

Technically there is a code path where things can get stuck if you send in a strange enough config. I'm not clear that code path is real, but it may be possible to get stuck waiting on a State for a thread that was never started.

codecov[bot] commented 2 years ago

Codecov Report

Merging #570 (d6d76bf) into master (6fa0bf4) will decrease coverage by 14.08%. The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #570       +/-   ##
===========================================
- Coverage   95.39%   81.31%   -14.09%     
===========================================
  Files          45       45               
  Lines        2716     2719        +3     
  Branches      442      495       +53     
===========================================
- Hits         2591     2211      -380     
- Misses         91      470      +379     
- Partials       34       38        +4
Flag Coverage Δ
python-3.10 81.24% <50.00%> (-14.01%) :arrow_down:
python-3.6 80.85% <50.00%> (-14.23%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../decisionengine/framework/engine/DecisionEngine.py 32.82% <0.00%> (-54.11%) :arrow_down:
src/decisionengine/framework/engine/Workers.py 68.49% <0.00%> (-19.01%) :arrow_down:
...ecisionengine/framework/taskmanager/TaskManager.py 86.73% <100.00%> (-11.65%) :arrow_down:
...rc/decisionengine/framework/modules/SourceProxy.py 26.08% <0.00%> (-52.18%) :arrow_down:
...cisionengine/framework/taskmanager/module_graph.py 64.15% <0.00%> (-35.85%) :arrow_down:
src/decisionengine/framework/dataspace/maintain.py 82.85% <0.00%> (-17.15%) :arrow_down:
...isionengine/framework/managers/ComponentManager.py 82.92% <0.00%> (-9.76%) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fa0bf4...d6d76bf. Read the comment docs.