HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 26 forks source link

Allow duplicate keys if their values are the same #589

Closed knoepfel closed 2 years ago

knoepfel commented 2 years ago

The utilities in de_std.libsonnet forbids duplicate keys. Although this prevents unintentional overwriting of configurations, it also prevents combining some configurations that use an identical configuration for a given key. This PR allows duplicate keys if the configuration values are the same.

codecov[bot] commented 2 years ago

Codecov Report

Merging #589 (11473c0) into master (1ea288e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #589   +/-   ##
=======================================
  Coverage   84.20%   84.20%           
=======================================
  Files          46       46           
  Lines        2748     2748           
  Branches      492      492           
=======================================
  Hits         2314     2314           
  Misses        390      390           
  Partials       44       44           
Flag Coverage Δ
python-3.10 84.13% <ø> (ø)
python-3.6 83.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ea288e...11473c0. Read the comment docs.

jcpunk commented 2 years ago

Can we break the pre-commit updates into a separate commit/PR?

knoepfel commented 2 years ago

@jcpunk, yep I'll make a separate PR.

knoepfel commented 2 years ago

See #592.

knoepfel commented 2 years ago

Will rebase this PR off of #592 once that is merged into master.

mambelli commented 2 years ago

I merged #592

jcpunk commented 2 years ago

pre-commit.ci run