HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 25 forks source link

Ensure de_std.libsonnet is installed #593

Closed knoepfel closed 2 years ago

knoepfel commented 2 years ago

The de_std.libsonnet file is not provided automatically via setuptools. This PR attempts to address this.

codecov[bot] commented 2 years ago

Codecov Report

Merging #593 (1bed376) into master (a4510cb) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #593   +/-   ##
=======================================
  Coverage   84.20%   84.20%           
=======================================
  Files          46       46           
  Lines        2748     2748           
  Branches      492      492           
=======================================
  Hits         2314     2314           
  Misses        390      390           
  Partials       44       44           
Flag Coverage Δ
python-3.10 83.95% <ø> (ø)
python-3.6 83.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4510cb...1bed376. Read the comment docs.

jcpunk commented 2 years ago

Hmmm the datafile doesn't appear in the CI rpm....

knoepfel commented 2 years ago

Hmmm the datafile doesn't appear in the CI rpm....

Yeah, I think I'll have more success with decisionengine.framework.config as the package instead of just config. Testing...

jcpunk commented 2 years ago

My local tests with that change look right to me.