Closed jcpunk closed 2 years ago
Merging #605 (2f3e83f) into master (dfe4278) will decrease coverage by
0.20%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #605 +/- ##
==========================================
- Coverage 96.25% 96.05% -0.21%
==========================================
Files 47 47
Lines 2829 2836 +7
Branches 447 449 +2
==========================================
+ Hits 2723 2724 +1
- Misses 77 83 +6
Partials 29 29
Flag | Coverage Δ | |
---|---|---|
python-3.10 | 95.76% <100.00%> (-0.21%) |
:arrow_down: |
python-3.6 | 95.60% <100.00%> (-0.24%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...aspace/datasources/sqlalchemy_ds/datasource_api.py | 98.78% <100.00%> (+<0.01%) |
:arrow_up: |
.../decisionengine/framework/engine/DecisionEngine.py | 87.96% <0.00%> (-1.06%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dfe4278...2f3e83f. Read the comment docs.
So all you are changing is one info statement and adding one after the create is done? Do I understand the diff correctly?
yep, I noticed in my test hosts that the create gets called a few times so the message is more accurate now.
Steve reported startup slowness creating the tables. This should tell us how long it took so we can look into what might be the cause.