HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 25 forks source link

Miscellaneous fixes for DE 2.0 #637

Closed knoepfel closed 2 years ago

knoepfel commented 2 years ago

This PR addresses the following issues:

codecov[bot] commented 2 years ago

Codecov Report

Merging #637 (1d0338b) into master (aeb6b97) will increase coverage by 0.25%. The diff coverage is 99.35%.

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
+ Coverage   97.26%   97.51%   +0.25%     
==========================================
  Files          49       49              
  Lines        2889     2941      +52     
  Branches      460      469       +9     
==========================================
+ Hits         2810     2868      +58     
+ Misses         53       49       -4     
+ Partials       26       24       -2     
Flag Coverage Δ
python-3.10 97.31% <99.35%> (+0.32%) :arrow_up:
python-3.6 97.09% <99.35%> (+0.36%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../decisionengine/framework/engine/DecisionEngine.py 93.45% <98.79%> (+1.32%) :arrow_up:
src/decisionengine/framework/dataspace/maintain.py 100.00% <100.00%> (ø)
.../decisionengine/framework/engine/ChannelWorkers.py 92.06% <100.00%> (+1.27%) :arrow_up:
...c/decisionengine/framework/engine/SourceWorkers.py 100.00% <100.00%> (ø)
src/decisionengine/framework/engine/de_client.py 100.00% <100.00%> (ø)
...ecisionengine/framework/taskmanager/TaskManager.py 97.46% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d739ec...1d0338b. Read the comment docs.

pep8speaks commented 2 years ago

Hello @knoepfel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-04-19 17:57:43 UTC