search

HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 25 forks source link

Fix over-logging of "Taking channel offline" message #647

Closed knoepfel closed 2 years ago

knoepfel commented 2 years ago

In the event that a source was taken offline due to an error, a message was logged every 0.5 seconds that the "channel" was being taken offline. This PR fixes the problem, emitting the message only when the source is taken offline. Incidentally, the logged message has been corrected to "Taking source ... offline", not the channel.

codecov[bot] commented 2 years ago

Codecov Report

Merging #647 (095f48d) into master (e10fe5a) will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
- Coverage   97.51%   97.48%   -0.04%     
==========================================
  Files          49       49              
  Lines        2941     2943       +2     
  Branches      469      470       +1     
==========================================
+ Hits         2868     2869       +1     
- Misses         49       50       +1     
  Partials       24       24
Flag Coverage Δ
python-3.10 97.28% <100.00%> (-0.04%) :arrow_down:
python-3.6 96.99% <100.00%> (-0.11%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/decisionengine/framework/engine/SourceWorkers.py 98.50% <100.00%> (-1.50%) :arrow_down:
.../decisionengine/framework/engine/DecisionEngine.py 93.62% <0.00%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e10fe5a...095f48d. Read the comment docs.