HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 25 forks source link

Use logging for XMLRPC client requests #652

Closed knoepfel closed 2 years ago

knoepfel commented 2 years ago

The DE server handles XMLRPC requests by returning a string to the client. This means the client caller waits until the string is returned, which can be lengthy for requests that take a long time to process.

This PR, instead of returning a string, uses logging on the server end so that requests with lengthy processing can be broken into different logged messages. This hopefully provides a more user-friendly approach.

codecov[bot] commented 2 years ago

Codecov Report

Merging #652 (383a90a) into master (76f3ddf) will increase coverage by 0.03%. The diff coverage is 94.66%.

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   97.36%   97.39%   +0.03%     
==========================================
  Files          49       49              
  Lines        2960     2959       -1     
  Branches      471      471              
==========================================
  Hits         2882     2882              
+ Misses         53       52       -1     
  Partials       25       25              
Flag Coverage Δ
python-3.10 97.22% <94.66%> (+0.03%) :arrow_up:
python-3.6 96.94% <94.59%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/decisionengine/framework/engine/de_query_tool.py 96.77% <0.00%> (+3.02%) :arrow_up:
.../decisionengine/framework/engine/DecisionEngine.py 93.16% <95.83%> (+0.04%) :arrow_up:
src/decisionengine/framework/engine/de_client.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76f3ddf...383a90a. Read the comment docs.

knoepfel commented 2 years ago

Closed in favor of a kombu-based solution.