Closed goodenou closed 2 years ago
Merging #653 (837c391) into master (76f3ddf) will decrease coverage by
1.31%
. The diff coverage is51.16%
.:exclamation: Current head 837c391 differs from pull request most recent head 1a8187a. Consider uploading reports for the commit 1a8187a to get more accurate results
@@ Coverage Diff @@
## master #653 +/- ##
==========================================
- Coverage 97.36% 96.04% -1.32%
==========================================
Files 49 49
Lines 2960 3036 +76
Branches 471 486 +15
==========================================
+ Hits 2882 2916 +34
- Misses 53 91 +38
- Partials 25 29 +4
Flag | Coverage Δ | |
---|---|---|
python-3.10 | 95.88% <51.16%> (-1.32%) |
:arrow_down: |
python-3.6 | 95.60% <51.16%> (-1.32%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
.../decisionengine/framework/engine/DecisionEngine.py | 90.34% <14.28%> (-2.77%) |
:arrow_down: |
src/decisionengine/framework/engine/de_client.py | 94.81% <30.00%> (-5.19%) |
:arrow_down: |
...c/decisionengine/framework/engine/SourceWorkers.py | 89.44% <68.51%> (-9.08%) |
:arrow_down: |
...sionengine/framework/modules/logging_configDict.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 76f3ddf...1a8187a. Read the comment docs.
Address issue 650:
Separate log files are now created for each source. Source log info is still added to the decisionengine_structlog_debug.log file, along with all other logging. The name of the logger is "source" (compare with "decisionengine" and "channel"). The "module" items in the log entries are the names of the sources, as given in the config file.
I ran tests using the channels job_classification and resource_request. The following files were created and populated: decisionengine_debug.log decisionengine.log decisionengine_structlog_debug.log FactoryEntriesSource.log FactoryGlobalManifests.log FigureOfMerit.log GceFigureOfMerit.log JobCategorizationSourceProxy.log job_classification.log JobManifestsSourceProxy.log jobs_manifests.log NerscFigureOfMerit.log resource_request.log StartdManifestsSource.log
An example log entry from decisionengine_structlog.log is: {"channel": "job_classification", "event": "Starting source loop for jobs_manifests", "level": "info", "logger": "source", "module": "jobs_manifests", "timestamp": "2022-05-27 18:51:32"}
An example log entry from FactoryEntriesSource.log is: 2022-05-27 18:51:33,259 - source - SourceWorkers - INFO - {"channel": "resource_request", "event": "Starting source loop for FactoryEntriesSource", "level": "info", "logger": "source", "module": "FactoryEntriesSource", "timestamp": "2022-05-27 18:51:33"}