search

HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 26 forks source link

Use kombu queues for partial handling of client/server requests #655

Closed knoepfel closed 2 years ago

knoepfel commented 2 years ago

This PR makes it possible to "stream" messages from the DE server to the client, providing the basis for more interactive de-client usage. This PR also addresses issue #639.

pep8speaks commented 2 years ago

Hello @knoepfel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-07-05 17:41:10 UTC
codecov[bot] commented 2 years ago

Codecov Report

Merging #655 (8664e76) into master (29a1ee2) will decrease coverage by 0.05%. The diff coverage is 94.14%.

@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
- Coverage   97.33%   97.27%   -0.06%     
==========================================
  Files          49       50       +1     
  Lines        3036     3120      +84     
  Branches      486      501      +15     
==========================================
+ Hits         2955     3035      +80     
  Misses         54       54              
- Partials       27       31       +4
Flag Coverage Δ
python-3.10 97.21% <94.14%> (+0.20%) :arrow_up:
python-3.6 96.87% <92.27%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/decisionengine/framework/engine/de_query_tool.py 89.18% <63.63%> (-4.57%) :arrow_down:
.../decisionengine/framework/engine/DecisionEngine.py 93.59% <94.57%> (+0.41%) :arrow_up:
src/decisionengine/framework/engine/de_client.py 98.54% <94.73%> (-1.46%) :arrow_down:
src/decisionengine/framework/dataspace/maintain.py 100.00% <100.00%> (ø)
.../decisionengine/framework/engine/ChannelWorkers.py 92.42% <100.00%> (+0.36%) :arrow_up:
...onengine/framework/engine/ClientMessageReceiver.py 100.00% <100.00%> (ø)
...sionengine/framework/taskmanager/LatestMessages.py 100.00% <100.00%> (ø)
...ecisionengine/framework/taskmanager/TaskManager.py 97.44% <100.00%> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 29a1ee2...8664e76. Read the comment docs.