Closed goodenou closed 1 year ago
This pull request introduces 1 alert when merging bd863ccc4e29cf7ffc324a55137944f4d18a788f into e0749d8b83c65345da9e18ddaa04f922c2b3c162 - view on LGTM.com
new alerts:
Base: 97.27% // Head: 97.28% // Increases project coverage by +0.00%
:tada:
Coverage data is based on head (
6431c64
) compared to base (e0749d8
). Patch coverage: 100.00% of modified lines in pull request are covered.:exclamation: Current head 6431c64 differs from pull request most recent head f120e0f. Consider uploading reports for the commit f120e0f to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Individual Source loggers were failing because of the addition of ChannelWorkers as different multiprocessing processes.
Each of the SourceWorker objects is a multiprocessing.Process that has its own logger based on the SOURCELOGGERNAME. Each SourceWorker also has a dict of Sources, each of which has its own logger which was based on the CHANNELLOGGERNAME, which is actually in another multiprocessing.Process. Any logging done by the Sources was thus not getting recorded.
I changed the design so that now the Sources get their logger from the SourceWorker; the logger is passed through as a parameter in the Source initialization.