HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 25 forks source link

explicitly select a container with all our required python versions #671

Closed jcpunk closed 1 year ago

jcpunk commented 1 year ago

This should resolve the issue with the runners not having the right python versions.

Our production pythons are: 3.6 and 3.9.

Testing against 3.11 should give us some forward looking advice.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.18% // Head: 97.31% // Increases project coverage by +0.12% :tada:

Coverage data is based on head (a7ce673) compared to base (669555c). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head a7ce673 differs from pull request most recent head cac7020. Consider uploading reports for the commit cac7020 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #671 +/- ## ========================================== + Coverage 97.18% 97.31% +0.12% ========================================== Files 51 51 Lines 3162 3165 +3 Branches 504 580 +76 ========================================== + Hits 3073 3080 +7 Misses 54 54 + Partials 35 31 -4 ``` | Flag | Coverage Δ | | |---|---|---| | python-3.10 | `?` | | | python-3.11 | `97.21% <100.00%> (?)` | | | python-3.6 | `97.04% <100.00%> (?)` | | | python-3.9 | `97.21% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/HEPCloud/decisionengine/pull/671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | Coverage Δ | | |---|---|---| | [...c/decisionengine/framework/engine/SourceWorkers.py](https://codecov.io/gh/HEPCloud/decisionengine/pull/671/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#diff-c3JjL2RlY2lzaW9uZW5naW5lL2ZyYW1ld29yay9lbmdpbmUvU291cmNlV29ya2Vycy5weQ==) | `97.77% <100.00%> (ø)` | | | [src/decisionengine/framework/modules/Source.py](https://codecov.io/gh/HEPCloud/decisionengine/pull/671/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#diff-c3JjL2RlY2lzaW9uZW5naW5lL2ZyYW1ld29yay9tb2R1bGVzL1NvdXJjZS5weQ==) | `100.00% <100.00%> (ø)` | | | [src/decisionengine/framework/dataspace/maintain.py](https://codecov.io/gh/HEPCloud/decisionengine/pull/671/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#diff-c3JjL2RlY2lzaW9uZW5naW5lL2ZyYW1ld29yay9kYXRhc3BhY2UvbWFpbnRhaW4ucHk=) | `100.00% <0.00%> (+3.77%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.