HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 26 forks source link

Fix unit tests #683

Closed vitodb closed 1 year ago

vitodb commented 1 year ago

Updated regexp in _expected_circularity Jsonnet keys are not in quotes.

This behavior change started with toposort 1.10, spefifically due to: this commit in toposort to Use f-strings instead of str.format()

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.13 :warning:

Comparison is base (fd3c5bd) 97.25% compared to head (92ff169) 97.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================== - Coverage 97.25% 97.12% -0.13% ========================================== Files 51 51 Lines 3164 3165 +1 Branches 431 517 +86 ========================================== - Hits 3077 3074 -3 - Misses 54 56 +2 - Partials 33 35 +2 ``` | Flag | Coverage Δ | | |---|---|---| | python-3.11 | `97.09% <100.00%> (?)` | | | python-3.9 | `97.09% <100.00%> (-0.16%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/HEPCloud/decisionengine/pull/683?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | Coverage Δ | | |---|---|---| | [src/decisionengine/framework/about.py](https://app.codecov.io/gh/HEPCloud/decisionengine/pull/683?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#diff-c3JjL2RlY2lzaW9uZW5naW5lL2ZyYW1ld29yay9hYm91dC5weQ==) | `100.00% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/HEPCloud/decisionengine/pull/683/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mambelli commented 1 year ago

The commit indicated by Vito is also switching from representation to string (this is the cause of the change in behavior). I opened an issue w/ toposort: https://gitlab.com/ericvsmith/toposort/-/issues/7