HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 26 forks source link

fix source logging in v1.7 #692

Closed mambelli closed 1 year ago

mambelli commented 1 year ago

fix source logging by defining logger in Sources after PR670 plus missing adjustments (e.g. adding SOURCELOGGERNAME definition)

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (670a618) 83.33% compared to head (b8a9585) 83.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 1.7 #692 +/- ## ========================================== + Coverage 83.33% 83.36% +0.02% ========================================== Files 45 45 Lines 2803 2807 +4 Branches 454 454 ========================================== + Hits 2336 2340 +4 Misses 427 427 Partials 40 40 ``` | [Flag](https://app.codecov.io/gh/HEPCloud/decisionengine/pull/692/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | Coverage Δ | | |---|---|---| | [python-3.6](https://app.codecov.io/gh/HEPCloud/decisionengine/pull/692/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | `83.09% <100.00%> (+0.02%)` | :arrow_up: | | [python-3.9](https://app.codecov.io/gh/HEPCloud/decisionengine/pull/692/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | `83.25% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/HEPCloud/decisionengine/pull/692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | Coverage Δ | | |---|---|---| | [src/decisionengine/framework/modules/Source.py](https://app.codecov.io/gh/HEPCloud/decisionengine/pull/692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#diff-c3JjL2RlY2lzaW9uZW5naW5lL2ZyYW1ld29yay9tb2R1bGVzL1NvdXJjZS5weQ==) | `100.00% <100.00%> (ø)` | | | [...sionengine/framework/modules/logging\_configDict.py](https://app.codecov.io/gh/HEPCloud/decisionengine/pull/692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#diff-c3JjL2RlY2lzaW9uZW5naW5lL2ZyYW1ld29yay9tb2R1bGVzL2xvZ2dpbmdfY29uZmlnRGljdC5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

StevenCTimm commented 1 year ago

The code looks ok to me although we will only find out if it actually fixes the problem once we merge it and run it in the final production configuration.