HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 25 forks source link

Find and consolidate hardcoded paths in DE code, and mock for unit tests #699

Open shreyb opened 5 months ago

shreyb commented 5 months ago

This issue consists of three parts:

This needs to be done for both the decisionengine code and decisionengine_modules code.

shreyb commented 4 months ago

I actually think the first two parts were done in #168. The current design, implemented by that PR, is that various modules import thedecisionengine.framework.config if they need access to the configuration. The submodules within that module contain functions to dynamically find the configuration files, validate them, and load their values into memory. This is the way it should be, IMO, so I see no need to change that.

That means that the bulk of the work here is actually on the testing side, and mocking where that config module looks for configuration files.

What do you think, @mambelli?