HEPCloud / decisionengine

HEPCloud Decision Engine framework
Apache License 2.0
6 stars 26 forks source link

Fixed bugs in metrics with labels #701

Closed IlyaBaburashvili closed 7 months ago

IlyaBaburashvili commented 8 months ago

Removed decorators in metrics with labels and moved timing inside function.

pep8speaks commented 8 months ago

Hello @IlyaBaburashvili! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-02-16 16:38:13 UTC
codecov[bot] commented 8 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (7fe99a6) 97.13% compared to head (321eefc) 97.16%. Report is 11 commits behind head on master.

:exclamation: Current head 321eefc differs from pull request most recent head acfdc38. Consider uploading reports for the commit acfdc38 to get more accurate results

Files Patch % Lines
.../decisionengine/framework/engine/DecisionEngine.py 87.91% 6 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #701 +/- ## ========================================== + Coverage 97.13% 97.16% +0.03% ========================================== Files 51 51 Lines 3172 3214 +42 Branches 518 539 +21 ========================================== + Hits 3081 3123 +42 Misses 56 56 Partials 35 35 ``` | [Flag](https://app.codecov.io/gh/HEPCloud/decisionengine/pull/701/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | Coverage Δ | | |---|---|---| | [python-3.11](https://app.codecov.io/gh/HEPCloud/decisionengine/pull/701/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | `97.13% <87.91%> (+0.03%)` | :arrow_up: | | [python-3.9](https://app.codecov.io/gh/HEPCloud/decisionengine/pull/701/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | `97.13% <87.91%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vitodb commented 8 months ago

With this PR now unit tests are happy. Tests for the PR were successful on Jenkins and also running unit tests interactively all tests went through. All test are passing, no more tests got stuck.