search

HEPCloud / decisionengine_modules

Apache License 2.0
2 stars 19 forks source link

Catch exceptions when no VMs running in GCE #408

Closed hyunwoo18 closed 2 years ago

pep8speaks commented 2 years ago

Hello @hyunwoo18! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-03-28 20:12:58 UTC
codecov[bot] commented 2 years ago

Codecov Report

Merging #408 (35df803) into master (ed2a8b4) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
- Coverage   39.12%   39.11%   -0.02%     
==========================================
  Files          71       71              
  Lines        3422     3426       +4     
  Branches      600      600              
==========================================
+ Hits         1339     1340       +1     
- Misses       1992     1995       +3     
  Partials       91       91
Flag Coverage Δ
python-3.6 39.01% <ø> (-0.02%) :arrow_down:
python-3.9 39.11% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nengine_modules/GCE/transforms/GceFigureOfMerit.py 87.17% <0.00%> (-7.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed2a8b4...35df803. Read the comment docs.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 9b652a27591154d73a4479d3a0e4129b0d3ee2f0 into ed2a8b425817ffe10325929b993c4c264899494f - view on LGTM.com

new alerts:

hyunwoo18 commented 2 years ago

Marco, I updated the branch to implement your comments. I am not sure if you received notification from GH about this.

mambelli commented 2 years ago

There is still some problem here, GH says "This branch cannot be rebased due to conflicts". Will look into it later. I may have to cherry-pick the changes

hyunwoo18 commented 2 years ago

Yes, when I was trying a rebase, there was a message that said to resolve a conflict in GCE/transforms/GceFigureOfMerit.py. I resolved the conflict and proceeded with git rebase --continue git add GCE/transforms/GceFigureOfMerit.py and pushed to origin/t381.

But I don't understand what more GH system is complaining about. I just followed what GH recommended.

Thinking again, maybe I should have just updated my code to reflect your change in the same file, GCE/transforms/GceFigureOfMerit.py instead of rebasing..

mambelli commented 2 years ago

Replaced by PR #413