HEPCloud / decisionengine_modules

Apache License 2.0
2 stars 19 forks source link

Fix de_client call #436

Closed vitodb closed 2 years ago

vitodb commented 2 years ago

This is required to allow de_client to get its output returned as text string rather then using a logger. This fixes an issue when using decisionengine_modules/glideinwms/configure_gwms_frontend.py to generate GWMS configuration from glideinwms.libsonnet Thanks to Kyle for the help to get the issue fixed.

codecov[bot] commented 2 years ago

Codecov Report

Base: 47.41% // Head: 47.41% // No change to project coverage :thumbsup:

Coverage data is based on head (a6744f1) compared to base (f2057d1). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #436 +/- ## ======================================= Coverage 47.41% 47.41% ======================================= Files 54 54 Lines 2902 2902 Branches 523 523 ======================================= Hits 1376 1376 Misses 1426 1426 Partials 100 100 ``` | Flag | Coverage Δ | | |---|---|---| | python-3.6 | `?` | | | python-3.9 | `47.41% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/HEPCloud/decisionengine_modules/pull/436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | Coverage Δ | | |---|---|---| | [...ecisionengine\_modules/glideinwms/DEConfigSource.py](https://codecov.io/gh/HEPCloud/decisionengine_modules/pull/436/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#diff-c3JjL2RlY2lzaW9uZW5naW5lX21vZHVsZXMvZ2xpZGVpbndtcy9ERUNvbmZpZ1NvdXJjZS5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.