HEPCloud / decisionengine_modules

Apache License 2.0
2 stars 19 forks source link

Sfapi #466

Closed hyunwoo18 closed 1 year ago

hyunwoo18 commented 1 year ago

It's been a while since I wrote DE code. Let me know of any obvious violation of guidelines

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (842fdc9) 47.23% compared to head (f020056) 47.23%. Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #466 +/- ## ======================================= Coverage 47.23% 47.23% ======================================= Files 54 54 Lines 2907 2907 Branches 498 498 ======================================= Hits 1373 1373 Misses 1433 1433 Partials 101 101 ``` | [Flag](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/466/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | Coverage Δ | | |---|---|---| | [python-3.8](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/466/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | `47.23% <ø> (ø)` | | | [python-3.9](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/466/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | `47.23% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | Coverage Δ | | |---|---|---| | [setup.py](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#diff-c2V0dXAucHk=) | `0.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hyunwoo18 commented 1 year ago

I opened another PR. Withdrawing this.