Closed BrunoCoimbra closed 7 months ago
Hello @BrunoCoimbra! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Unit tests are still failing because /etc/decisionengine
is missing.
Running unit tests in a container, where the folder /etc/decisionengine
exists, it also reports another failure.
Attention: 10 lines
in your changes are missing coverage. Please review.
Comparison is base (
5a5fb8b
) 47.23% compared to head (1428f4e
) 47.22%. Report is 8 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
...ngine_modules/glideinwms/glide_frontend_element.py | 0.00% | 10 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
With last set of updates unit tests are good. On Jenkins there are still tests failing due to the M2Crypto issue in GWMS, but this is happening because the current Jenkins setup uses branch_v3_9 for GWMS instead of master.
This PR fixes and improves some tests related to the
configure_gwms_frontend
script.