search

HEPCloud / decisionengine_modules

Apache License 2.0
2 stars 19 forks source link

Added new metrics to job_q and source #489

Closed IlyaBaburashvili closed 6 months ago

IlyaBaburashvili commented 7 months ago

dem_htcondor_jobs_status_count - Monitors number of jobs classified per status (idle,running, removed, completed, held, transferring_output, suspended)

dem_htcondor_slots_status_count- Monitors number of glideins available for the client based on status.

pep8speaks commented 7 months ago

Hello @IlyaBaburashvili! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-02-19 05:34:35 UTC
codecov[bot] commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8a07b0e) 47.22% compared to head (61384d7) 47.51%. Report is 3 commits behind head on master.

:exclamation: Current head 61384d7 differs from pull request most recent head 85f195f. Consider uploading reports for the commit 85f195f to get more accurate results

Files Patch % Lines
...c/decisionengine_modules/htcondor/sources/job_q.py 62.50% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #489 +/- ## ========================================== + Coverage 47.22% 47.51% +0.28% ========================================== Files 54 54 Lines 2918 2932 +14 Branches 504 506 +2 ========================================== + Hits 1378 1393 +15 Misses 1439 1439 + Partials 101 100 -1 ``` | [Flag](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/489/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | Coverage Δ | | |---|---|---| | [python-3.8](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/489/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | `47.51% <80.00%> (+0.28%)` | :arrow_up: | | [python-3.9](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/489/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | `47.51% <80.00%> (+0.28%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.