search

HEPCloud / decisionengine_modules

Apache License 2.0
2 stars 19 forks source link

Add dem_htcondor_cores_count and dem_htcondor_cores_histogram metrics to source.py #493

Closed IlyaBaburashvili closed 7 months ago

IlyaBaburashvili commented 8 months ago

New gauge and histogram metrics for counting cores.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.84%. Comparing base (21ac8c4) to head (51dd79e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #493 +/- ## ========================================== + Coverage 47.51% 47.84% +0.33% ========================================== Files 54 54 Lines 2932 2951 +19 Branches 506 510 +4 ========================================== + Hits 1393 1412 +19 Misses 1439 1439 Partials 100 100 ``` | [Flag](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/493/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | Coverage Δ | | |---|---|---| | [python-3.8](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | `47.84% <100.00%> (+0.33%)` | :arrow_up: | | [python-3.9](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/493/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | `47.84% <100.00%> (+0.33%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pep8speaks commented 7 months ago

Hello @IlyaBaburashvili! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-03-19 19:41:45 UTC